search

bethlakshmi / GBE

Code repository for the Great Boston Burlesque Expo
3 stars 0 forks source link

Users are identified by Stage Name only #90

Open jonkiparsky opened 10 years ago

jonkiparsky commented 10 years ago

A user who does not enter a stage name is invisible in many places on the site, for example in assigning to "GM" roles. There are several directions we could take to solve this.

  1. "Soft path": inform users at signup that it would be a Very Good Idea to provide a Stage Name if they want to register for GM-type roles. (This is marketing language, so I'm not going to write it)
  2. "Hard path" 1: require Stage Name in profile
  3. "Hard path" 2: construct Stage Name from First/Last if not present, require First/Last
  4. "Middle Way": Do some validation and warn users if they submit w/o Stage Name filled in, but allow it.
  5. Ignore it and hope everyone submits a stage name
bethlakshmi commented 10 years ago

I think you are seeing edge cases that I didn't know where there and didn't manage to update.

The logic in the places that work is:

Please default to DisplayName in all forms.

If you find a place where DisplayName is blank, tell me how you got there and log is as a bug.

-Betty

On Tue, Nov 12, 2013 at 9:25 PM, Jon Kiparsky notifications@github.comwrote:

A user who does not enter a stage name is invisible in many places on the site, for example in assigning to "GM" roles. There are several directions we could take to solve this.

  1. "Soft path": inform users at signup that it would be a Very Good Idea to provide a Stage Name if they want to register for GM-type roles. (This is marketing language, so I'm not going to write it)
  2. "Hard path" 1: require Stage Name in profile
  3. "Hard path" 2: construct Stage Name from First/Last if not present, require First/Last
  4. "Middle Way": Do some validation and warn users if they submit w/o Stage Name filled in, but allow it.
  5. Ignore it and hope everyone submits a stage name

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/90 .

jonkiparsky commented 10 years ago

Where I've been noticing it is in Bids. I think it just feels like I've seen it all over, but that's probably the only place.

Try submitting a bid with a user w/o stage name.

Is this a case for making a User object in gbe_users?

bethlakshmi commented 10 years ago

How much time will it take to make a User object and put it everywhere ??

I agree on the need, but (sight unseen, my dev machine is in the shop right now) - I'm willing to bet that fixing a bug in Bids to use DisplayName is a 5 minute fix, creating a user object is 4 hours to create, and 8 or more hours to integrate given the spagetti like nature of the code.

And there's a subtler issue too - Bids and Acts are imitations of each other. There were so many case statements in Bids that when I needed to build out Acts.php, I couldn't take it, but I did it quick and dirty - Acts is a copy of the file with moderately heavy modification. Generally I've been the person working in that area, and I knew that if I found a bug in one place, I should check the other... but no one's perfect. If you found the function, you could compare it to Acts and see if they are both alike.

-Betty

On Thu, Nov 14, 2013 at 2:13 AM, Jon Kiparsky notifications@github.comwrote:

Where I've been noticing it is in Bids. I think it just feels like I've seen it all over, but that's probably the only place.

Try submitting a bid with a user w/o stage name.

Is this a case for making a User object in gbe_users?

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/90#issuecomment-28463854 .

bethlakshmi commented 10 years ago

Did you fix this? I just tried making a user with no stage name and submitting the bid and it went in fine? If it doesn't work - feel free to bounce it back at me, but it would help to have a failing user in the test database if that's the case.