bethylamine / soupcan

A cross-browser extension for Twitter to bring @WhatIsAWomanBot features into your browser.
GNU General Public License v3.0
20 stars 2 forks source link

Change the way access can be permanently granted for mobile users to … #120

Closed bethylamine closed 8 months ago

bethylamine commented 8 months ago

…remove webNavigation permissions

For issue #119

@INSANEMODE can you test that this works as intended? There is a button on the options page that, when clicked, will request the needed permissions.

INSANEMODE commented 8 months ago

Button seems to work as intended on Firefox for Android, and doesn't do anything when pressed when the permissions have previously been granted.

This is how it looks on my end. image

Seems good enough for the moment to prevent users from having to grant a new permission. Do you want to keep the button like this, or have it only exist when needed? (when on mobile/when the host permissions aren't granted?)

bethylamine commented 8 months ago

only when needed ideally

On Tue, Apr 2, 2024 at 17:28, INSANEMODE @.***(mailto:On Tue, Apr 2, 2024 at 17:28, INSANEMODE < wrote:

Button seems to work as intended on Firefox for Android, and doesn't do anything when pressed when the permissions have previously been granted.

This is how it looks on my end. image.png (view on web)

Seems good enough for the moment to prevent users from having to grant a new permission. Do you want to keep the button like this, or have it only exist when needed? (when on mobile/when the host permissions aren't granted?)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

INSANEMODE commented 8 months ago

Ok we can do this pretty easily. I don't have write access to change anything in this pull request, and i can't suggest changes to code that hasn't been modifed in a code review, so i guess i'll just make the changes on my own branch and make another pull request to this branch to show what i am thinking.

122

bethylamine commented 8 months ago

Look good. approved and merged.