search

bethylamine / soupcan

A cross-browser extension for Twitter to bring @WhatIsAWomanBot features into your browser.
GNU General Public License v3.0
19 stars 2 forks source link

Merge manifests #129

Closed INSANEMODE closed 4 weeks ago

INSANEMODE commented 5 months ago

Merged manifests into one.

Starting with Firefox and chrome version 121 (December 2023/January 2024), a single manifest can be used without causing problems.

Since Firefox doesn't properly support service workers, it will now ignore background.service_worker, and will still generate the background page if one is in the manifest.

And on chrome, if background.service_worker exists, background.scripts will be ignored.

There will still be warnings about these changes, but they no longer break things.

This isn't really needed, and it will raise the minimum supported browser version for both browsers, but can make testing multiple browsers at once easier, if that isn't a concern.

INSANEMODE commented 5 months ago

The menus permission is in this manifest, but it shouldn't affect chrome, since it doesn't have a permission by that name, and it only produces a warning. I doubt it will try to ask users to grant a new permission, since it doesn't exist.

I don't have any issues running through web-ext run, anyway.

bethylamine commented 5 months ago

I think we still want to support older browsers though. I don't have data on which browser versions people are using but if this is a new feature that would stop the plugin working on a significant portion of the install base, we should wait

INSANEMODE commented 5 months ago

That is entirely fair, especially when it doesn't do anything for the end user.