search

beyond-all-reason / BYAR-Chobby

Currently used legacy lobby for BAR, for the new lobby development see https://github.com/beyond-all-reason/bar-lobby
59 stars 72 forks source link

Fix Ignorelist #440

Closed FIr3baL closed 1 year ago

FIr3baL commented 1 year ago

  1. Parsing of IGNORELIST command results in last added ignore user as the only only one in LibLobby's internal ignorelist. Because it's not updated after IGNORELISTEND, but on each IGNORELIST command and then overwritten by a single entry. Though the flag isIgnored of each lobby.user is getting updated. (which is commonly used by widgets; duplicate data storing)

  2. Adding a user to ignorelist does not change users's shown color Reason is Teiserver not answering with spring protocol defined IGNORED command, so chobby does not refresh ignorelist.

ToDo:

  1. Update internal ignorelist after IGNORELISTEND as a whole
  2. After sending IGNORE to server, just send IGNORELIST 2-3 seconds later to receive the updated server state
FIr3baL commented 1 year ago

Teiserver is working correctly, just not answering with IGNORED , but with full Ignorelist, which is even better :) All fixed 👍