search

beyond-all-reason / BYAR-Chobby

Currently used legacy lobby for BAR, for the new lobby development see https://github.com/beyond-all-reason/bar-lobby
59 stars 72 forks source link

"You are now playing" not heard when in replay #463

Open FIr3baL opened 1 year ago

FIr3baL commented 1 year ago

Should be caused by chobby buffering commands when a game is running. As a result, chobby doesn't get to know about the corresponding status change and therefore doesn't play the notification sound.

Could be solved by not buffering commands, when a) being in a join queue AND b) spectating a game

A better approach (under same conditions like above) could be to filter incoming commands while buffering for ClientBattleStatus myUserName ...,; Then do sth like: a) bring up chobby (which will unbuffer the queued commands) OR b) Just play the sound (so user may react and switch to chobby manually) b1) And route the notification message into game chat, if technical possible. no clue ???

The buffering is done to have a better overall performance in game. So the change would come with a more or less performance break-down.

Maybe make it a toggle in settings and keep current behaviour as default.

WatchTheFort commented 1 year ago

Isn't everyone watching a replay spectating by definition? Isn't this message not applicable?

FIr3baL commented 1 year ago

Isn't everyone watching a replay spectating by definition? Isn't this message not applicable?

lol, absolutly - edited comment above

FIr3baL commented 1 year ago

!Ring sound should be heard ingame as well. E.G. you watching replay of last game while having a seat and you don't hear the ring sound.

FIr3baL commented 1 year ago

Just pushed: play the notification sound "You are now a player", while you are spectating a game It's only working for the most common use case, that is: I am launching a multiplayer game (pressed rejoin while a game is ongoing or we were just a regular spec when a game starts) I must be a spectator( or in join queue) before clicking rejoin

Downsides: It's not working, when you join a not full lobby, get a player in lobby and launch that game while being a player in lobby Not working, when you play a singleplayer game while waiting in a queue

Pros: It's working for playing a replay while in a queue