search

beyond-all-reason / BYAR-Chobby

Currently used legacy lobby for BAR, for the new lobby development see https://github.com/beyond-all-reason/bar-lobby
56 stars 66 forks source link

Bugfix - Lobby player size is not displaying correctly (3v3 shows 16 players for ex.) #551

Open gabrsar opened 7 months ago

gabrsar commented 7 months ago

Hi everyone, here is my first attempt to contribute with BAR, if I'm doing something wrong, please, let me know. Didn't found any contributing instructions.

One thing that is weird or misleading, is that on games that are not 8v8 or something like, with 16 players the lobby still shows 16 player slots available.

This can make hard for players looking for a "almost full" lobby to join or something like. image

This number should be displayed as team size x team count values defined on lobby config right? image

Right now doesn't looks like players use those inputs at all (at least as far as my limited experience shows)

I would like to try to implement that if it's the right way to do and I'm reasoning correctly about that. Also would gladly accept any suggestions or links to follow. Just have been able to start lobby in Dev mode following the instructions.

Anyway, thank you very much for this amazing game you all did!

Beherith commented 7 months ago

That is absolutely a wonderful feature idea thats been on the list. team size x team count is indeed correctly, however, do note that the protocol doesnt explicitly specify it. I recommend setting the chobby to devmode and ticking the debug server messages setting within it to see the protocol comms dump.

Beherith commented 7 months ago

Also, feel free to ping me or Fireball on discord at any time in the #Chobby channel :)