search

beyond-all-reason / BYAR-Chobby

Currently used legacy lobby for BAR, for the new lobby development see https://github.com/beyond-all-reason/bar-lobby
56 stars 66 forks source link

Expand Username Blacklist #555

Closed DeviousNull closed 3 months ago

DeviousNull commented 7 months ago

This PR seeks to improve the utility and scope of the existing username validation checks performed in the login window.

It does this in two stages:

In the first patch, a new Word_Library module is added, and the Login_Window class is migrated to use this module instead of implementing it itself. The goal with this migration is to facilitate the bulk addition of blacklisted strings by automatically normalizing entries. The existing blacklist is preserved, so this patch should not cause any functional/visible changes.

In the second patch, many new entries are added to the Word_Library blacklist. These are based on previously-encountered usernames which the BAR moderation team has required users to change.

Beherith commented 7 months ago

The second existing list is specifically not very useful, as those nicks are already taken/banned :D How about reformulating the rules to catch them?

DeviousNull commented 4 months ago

Well, I missed GitHub's notification and forgot about this for a good while, but the latest patch replaces the exact-username section with some extra entries in the other sections, which are more likely to be reused in the future.

AntlerForce commented 4 months ago

Needs rebasing. Screenshot_%T_%d-153

DeviousNull commented 4 months ago

Rebased (and retested) as requested.