search

beyond-all-reason / BYAR-Chobby

Currently used legacy lobby for BAR, for the new lobby development see https://github.com/beyond-all-reason/bar-lobby
56 stars 66 forks source link

Shadows in userhandler fonts #557

Closed Beherith closed 6 months ago

Beherith commented 7 months ago

https://github.com/beyond-all-reason/BYAR-Chobby/blame/c6c48ca6190bf9ebb041118d079e9b137b16cee1/LuaMenu/widgets/api_user_handler.lua#L918C20-L918C20

@AntlerForce I had to remove the shadow here, is it really needed? If yes, then the results of getfont with shadow should be cached into a local earlier just once and reused later for the objectoverridefont. Otherwise {shadow = false } triggers a font reallocation

AntlerForce commented 7 months ago

Possibly {outline = false} has the same problem. We should search for unneeded uses of {outline = true} and {shadow = true} as well.