search

beyond-all-reason / BYAR-Chobby

Currently used legacy lobby for BAR, for the new lobby development see https://github.com/beyond-all-reason/bar-lobby
56 stars 66 forks source link

Increase energy conversion efficiency cap from 1 to 10 #558

Closed RealArgonwolf closed 7 months ago

RealArgonwolf commented 7 months ago

This brings it in line with the other resource setting caps and allows additional freedom of experimentation.

6AKU66 commented 7 months ago

@Damgam Do you have something to say about this?

Damgam commented 7 months ago

I don't even know why it's capped at 1 lol

RealArgonwolf commented 7 months ago

I don't even know why it's capped at 1 lol

Me neither, I just assumed a developer thought it was too much power to give to mere mortals or something.

RealArgonwolf commented 7 months ago

@Damgam So... are you able to merge it? I'm pretty unfamiliar with the development process, I don't really know who's allowed to merge pull requests into the main branch. Is there anything I still need to do before it can be merged?

6AKU66 commented 7 months ago

I think it's pretty safe, i don't think that you can cause problems (aside of lag because of amount of units that gonna be produced) with it.