search

bezmi / jvc_projector

Python library to control JVC projectors
MIT License
16 stars 10 forks source link

Added two picture mode commands (HDR and Cinema) #2

Closed atrus05 closed 4 years ago

atrus05 commented 4 years ago

2 Picture mode commands added. This is basically my first pull request, so please be careful when checking this out :)

bezmi commented 4 years ago

Awesome, looks like it should work. Have you tested on your X5900? You can see here for an example.

atrus05 commented 4 years ago

I have not, as I do not have Home Assistant yet. I wanted to know if things like this would work before reworking my infrastructure around HASS. But I have tested it using a python script instead, which I call via Apple Shortcuts. So I can tell Siri to turn the projector on, and also off, and now to switch over to Cinema, and HDR mode. Which is pretty sweet. I will most likely install HASS in the future as I now know this is a project that is maintained, and which I now know a little about. And even contributed to (even though at a miniscule level) :)

bezmi commented 4 years ago

You don't need homeassistant to use this, you can just follow the example i linked above and type the commands into the python interpreter. I will test it later tonight, so no hurry.

atrus05 commented 4 years ago

Finally got around to test it this weekend, and my changes work just fine with your standalone solution. So it is now tested and you should be able to merge.

bezmi commented 4 years ago

Done. Will be putting out a new release of the python package relatively soon.