Introduced command to retrieve PowerState and cleanup

bezmi / jvc_projector

Python library to control JVC projectors

MIT License

16 stars 10 forks source link

Introduced command to retrieve PowerState and cleanup #5

Closed markprins closed 3 years ago

markprins commented 4 years ago

It introduces a new command to retrieve the PowerState, which is usefull within Home Assistant.

Further I introduced a (global) delay for successive commands (which could be a bit better as it now waits after the command instead of checking if it had ran in the last X seconds, maybe I'll ammend the PR). This should (partially) fix issue #3.

I also did a little cleanup (removed double sock.close(), and some code cleanup)

markprins commented 4 years ago

I agree with your statements! I have resolved them and updated the pull request.

bezmi commented 4 years ago

This looks good, I will give it a quick test when I have time and then merge it, cheers.

bezmi commented 3 years ago

I have merged your changes, apologies for the massive delay. Please let me know if things are broken!