bgultekin / laravel4-datatables-package

Server-side handler of DataTables Jquery Plugin for Laravel 4
267 stars 108 forks source link

TO DO #122

Open ktunkiewicz opened 10 years ago

ktunkiewicz commented 10 years ago

Hello people.

I reviewed all issues that exists for this package and came to some conclusions.

In my opinion these are things that should be fixed / developed in next releases:

I'll start working on these issues now. \ If there is anybody how have some time to help me writing or testing please tell me**

\ Closed issues **

merlosy commented 10 years ago

Hi,

I just released an small extension for MongoDB of your package: https://github.com/merlosy/php-mongo-datatables It uses your latest release with datatables 1.9 (still need to update this one).

Everything seems to be working so far.. I tried as simple query as below

public function getData()
    {
        $users = User::select(array('_id', 'name', 'email', 'created_at'));

        return MongoDatatables::of($users)->make();
    }

And it displays just fine.

Do you think there is a way to merge our work?

Cheers

ktunkiewicz commented 10 years ago

It look like your package is based on the same code so it should be easy to apply your changes into this package. I don't see any filtering or sorting functions in your package, this may be troublesome but I was planing to do it anyway. Maybe you can make a fork of this package and try to apply some basic changes and if it will work fine I'll marge it into this project. What do you think about it?

ktunkiewicz commented 9 years ago

\ Closed issue with "caching of queries" **

I removed caching between counts - couldn't find any better method,I failed to find a method of clearing cache between queries as Laravel cache helper didn't work inside this method.

ktunkiewicz commented 9 years ago

Updated issue "change count functions" description. This seems to work much better after last changes, but there is still problem if you use having clause in your query (#140)