search

biasmv / pv

WebGL protein viewer
https://pv.readthedocs.org
MIT License
316 stars 85 forks source link

Unexpected spheres rendering using setShowRelated( ) #171

Open giagitom opened 7 years ago

giagitom commented 7 years ago

Hi! I have seen strange spheres rendering while using setShowRelated( ). The images should explain what I mean. Tilting the view can increase the wried effect until spheres completly disappear.. This happens only with spheres style and only in the symmetric moieties shown by setShowRelated(), while cartoon and ballAndSticks work fine. For this image i used a protein with a dimeric biological assembly and a monomeric asymmetric unit (PDB code: 1C0K).

image

biasmv commented 7 years ago

Thanks for the report. Indeed, there is something wrong here. The issue is caused by the additional transformation that is applied when rendering symmetry-related copies of the asymmetric unit. This additional transformation is not taken into account when rendering the spherical billboard.

I'll look into providing a fix for this issue.

giagitom commented 7 years ago

Thank you!