bihealth / cubi-tk

CUBI Tooling for SODAR, VarFish et al.
MIT License
4 stars 6 forks source link

Newest varfish-cli is not compatible with python 3.8 #214

Closed Nicolai-vKuegelgen closed 1 month ago

Nicolai-vKuegelgen commented 8 months ago

Describe the bug cubi-tk CI currently tests against python 3.8, 3.9 & 3.10. cubi-tk also imports the varfish-cli (which tests 3.10-3.12). The varfish-cli started using typing.Annotated in version 0.6.*, which is not available in python 3.8 and thus breaks the cubi-tk tests run under that version.

To Reproduce Steps to reproduce the behavior:

Expected behavior Since we likely want to keep using the newest varfish-cli version, it seems that we need to drop python 3.8 support.

sellth commented 8 months ago

Easiest fix: Update our python versions to 3.10+

Nicolai-vKuegelgen commented 1 month ago

Circumvented as of #222