Closed mikkonie closed 2 months ago
In certain places in the tests, I've noticed us waiting for an arbitrary amount of seconds before checking the existence of something. Example in projectroles.tests.TestProjectCreateView.test_settings_label_icon():
projectroles.tests.TestProjectCreateView.test_settings_label_icon()
select.select_by_value('PROJECT') WebDriverWait(self.selenium, 10)
This is incorrect, as it doesn't even do anything. The .until() statement is missing.
.until()
We should look for cases where this is done and fix these occurrences.
Done together with #817.
mikkonie
commented
2 months ago
In certain places in the tests, I've noticed us waiting for an arbitrary amount of seconds before checking the existence of something. Example in
projectroles.tests.TestProjectCreateView.test_settings_label_icon():This is incorrect, as it doesn't even do anything. The
.until()statement is missing.We should look for cases where this is done and fix these occurrences.