bihealth / sodar-core

SODAR Core: A Django-based framework for building scientific data management web apps
MIT License
9 stars 1 forks source link

Move projectroles base test classes and helpers to base module(s) #1431

Open mikkonie opened 3 months ago

mikkonie commented 3 months ago

We should consider moving projectroles base test classes and helpers, which are expected to be used in SODAR Core using sites, into base module(s) instead of having them in the same module as SODAR Core specific test cases.

IMHO this would make it easier to manage base classes and helpers, differentiate them from tests and make the test case modules less bloated. As an example, one can look at the projectroles UI tests where the helpers take up quite a bit of the already rather large module.

This is something I have already done in SODAR with taskflowbackend tests and it clarified things a whole lot.

I'll still have to think further about whether this is a good idea or not, this issue is moslty intended as a note-to-self. Comments are welcome of course. This will not be done before at least v1.1, hence the tag.

See also #1253.