RemoteSite.get_access_date() fails if one or more dates are None

bihealth / sodar-core

SODAR Core: A Django-based framework for building scientific data management web apps

MIT License

9 stars 1 forks source link

RemoteSite.get_access_date() fails if one or more dates are None #1437

Closed mikkonie closed 2 months ago

mikkonie commented 2 months ago

The get_access_date() method in RemoteSite fails if some of the projects have date_access set to None. When sorting by -date_access, the first result is not the latest date but None. We should omit null resuts from this method.

Tests need to be updated to take this into account, of course.

Also, existing usages of get_access_date() should of course be checked..

mikkonie commented 2 months ago

Fixed.