search

bihealth / sodar-core

SODAR Core: A Django-based framework for building scientific data management web apps
MIT License
9 stars 1 forks source link

Expand data types in app plugin settings #1439

Closed stolpeo closed 2 months ago

stolpeo commented 2 months ago

Problem

Currently, only BOOLEAN, STRING and INTEGER are allowed datatypes in the app settings of the app plugins.

Solution

It would be nice to have more datatypes like JSON and FLOAT.

Alternative Solutions

Store all other datatypes as STRING and convert.

stolpeo commented 2 months ago

@mikkonie also, is there a max string length for datatype STRING?

mikkonie commented 2 months ago

JSON is already there and has been since the beginning. As for FLOAT, good idea.

There is a maximum value of 255 for the value in the model. I'm not sure why though, this can definitely be lifted.

mikkonie commented 2 months ago

Adding the FLOAT type should be trivial, just some work needed in validating and testing. Is there an existing use case for this? That is, should I include it in the v1.0 milestone?

stolpeo commented 2 months ago

If JSON is available, the current use-case would be covered by that. Currently no need.

mikkonie commented 2 months ago

Closing this issue, as all the questions appear to be solved. We can open a separate ticket for adding the FLOAT data type, if more need arises for it.