search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Investigation display name may appear empty in timeline events #1836

Closed mikkonie closed 10 months ago

mikkonie commented 10 months ago

I have an example ISA-Tab in which the investigation name appears empty for associated timeline events, even when using a SODAR Core version in which bihealth/sodar-core#1338 has been fixed.

The (unnamed) label does appear for sheet_delete events, which also assigns it to the reference in previous timeline events referring to the same object reference. However, for sheet_create and sheet_replace, these are not visible. I need to investigate this further.

2023-11_timeline_inv

mikkonie commented 10 months ago

This happens because we still can return an empty string in get_object_link() and timeline does not replace that. This will be fixed by bihealth/sodar-core#1341. However, we should still return a specific placeholder for Investigation objects.

mikkonie commented 10 months ago

This has been fixed in SODAR Core dev, closing.