bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Modifying iRODS delete requests created prior to action constant update fails #1858

Closed mikkonie closed 10 months ago

mikkonie commented 10 months ago

EDIT: This turned out to be something totally different from what I originally thought, so I'm rewriting the description.

In certain cases, trying to modify delete requests results in the following error:

Accepting iRODS data request "Delete path/to/object" failed: ['This model currently only supports the action "DELETE"']]

At first I thought this had something to do with the file status, but no: it's because 1 we recently changed the status in code to constants, 2) we changed the capitalization between the original strings and the new constants, but 3) comparison is case sensitive.

It's an easy fix: make the comparison in IrodsDataRequest._validate_action(), make the comparison case insensitive.

Also, that formatting error has to be corrected :) I believe that concerns batch accept/reject.

mikkonie commented 10 months ago

Fixed.