search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Refactor IrodsDataRequest creation/update #1865

Open mikkonie opened 6 months ago

mikkonie commented 6 months ago

I seem to have ran into another yak shaving session here.. In IrodsDataRequestCreateView and IrodsDataRequestUpdateView, we do a lot of model updating stuff in form_valid(), when it should be done in the form instead. This was also the cause of #1864. I'll refactor when I have a bit of spare time.

It seems something similar also happens in the IrodsAccessTicket views, to be investigated.

mikkonie commented 4 months ago

Similar to #1907, postponing this to v1.0 as it's a purely internal refactoring thing.