search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Display protocol names in ColumnToggleModal #1874

Open sellth opened 5 months ago

sellth commented 5 months ago

Protocol names are not shown as part of the process groups within the column filter dialogue. Especially when multiple subsequent process nodes are present, this can be confusing.

grafik

mikkonie commented 5 months ago

This is not a bug. Name nodes are not allowed to be hidden (this includes protocol names), so they are not displayed. Also, even though in practice the protocol name is (almost?) always the same for each row in a column in our studies, technically they are allowed to be different. So what would even be shown here?

Closing this issue, but feel free to formulate a feature request if you have an idea how to improve the layout.

sellth commented 5 months ago

This is related to #1875. Choosing different values within one Protocol REF column makes no sense to me and should imho not be allowed. We should definitely not sacrifice UX because of technicalities such as this.

This is how it could look like: process_mock

mikkonie commented 5 months ago

Choosing different values within one Protocol REF column makes no sense to me and should imho not be allowed. We should definitely not sacrifice UX because of technicalities such as this.

This is how it was specified to be implemented. If we want to restrict each process column to a single value, that is perfectly OK with me as it simplifies things a lot. However, that is a completely different issue than what you have raised here. And to reiterate, restricting the value is the default anyway.

If we have consensus on restricting the process value to a single value per column, the suggestion above is valid.

Also, if this "reopening closed issues" business continues, I'll have to review access rights to the repo.