Closed mikkonie closed 5 months ago
Confirmed to happen locally on a similarly sized sample sheet. Froze my dev laptop for 10 minutes before crashing with the same error as above, confirmed as relevant then. Next step: look closer into the flow and debug.
EDIT: This works locally if create_colls=True
but restrict_colls=False
. Either there is something crash-prone in SetAccessTask
, or taskflow simply can't handle such a large number of tasks in a linear queue. In the latter case, moving the functionality of that task (and potentially CreateCollectionTask
) into a batch-based task should help. I'll look into it further.
Switching from CreateCollectionTask
to BatchCreateCollectionTask
already made this work on my dev machine, albeit slowly. I'll set up a batch version of SetAccessTask
and use it here. After that we should again be future proof for a little while :)
Fixed.
Recently I optimized
landing_zone_move
to work better with very large projects. However, it seems thatlanding_zone_create
can still fail.I just witnessed the create flow crashing on a large project of 5000+ samples with
create_collectons
enabled. Upon first glance it would seem it already crashed in thePREPARING
state. I also verified that the celery job has since been terminated, so this wasn't just a case of "unoptimized code runs for days".Celery reports the following (not 100% sure if related, but nothing else was failing at the time, so most likely):
Can't see the SODAR logs since I can't access it in our Sentry at the moment.
I'll have to try to reproduce this locally with a similar sample sheet.