search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Uncaught exceptions in SetAccessTask #1906

Closed mikkonie closed 9 months ago

mikkonie commented 9 months ago

Something I encountered while looking into #1905. The following section is not properly enclosed in try-except:

if obj_target:
    target = self.irods.data_objects.get(path)
    recursive = False
else:
    target = self.irods.collections.get(path)
    recursive = recursive
target_access = self.irods.permissions.get(target=target)

As far as I can tell this is not the cause of #1905, but it should still be caught. It is possible that in a wrongly implemented flow we e.g. call this on a path which does not exist.

mikkonie commented 9 months ago

Fixed.