search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Review irodsbackend API and session handling in taskflowbackend #1907

Open mikkonie opened 9 months ago

mikkonie commented 9 months ago

I noticed an illogical bit of implementation in taskflowbackend.

Since this commit, irods_backend must be explicitly provided to taskflow iRODS tasks in the arguments of execute() and revert(). However, the same tasks access the iRODS session via self.irods. That session, of course, couldn't exist without first initializing self.irods_backend. Hence providing one of these in the method args but referring to the class variable for the other is illogical.

Usually I try to document all changes I make, but this time it seems I haven't written down the justification for this anywhere. I'll have to see whether providing the backend API as an arg has any relevant functionality. Either both of these have to be provided as args, or neither of them.

mikkonie commented 8 months ago

Postponing this to v1.0, as it's purely an internal issue and I want to get v0.14.2 out.