search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Increase CharField length for samplesheets models #1942

Open mikkonie opened 1 month ago

mikkonie commented 1 month ago

The default CharField length is set to 255 in samplesheets models. This is causing problems with longer values such as links.

I can't think of a reason for the limit to be so low, probably a case of "it seemed reasonable at the time".

The length should be increased. I'll have to look into what is an appropriate length and which fields should be altered. This limit comes from DEFAULT_LENGTH which is used in quite a few places.

mikkonie commented 1 month ago

Looking more closely, this limit mostly only applies to name fields and a few specific fields (technology platform, performer, array design ref, protocol version). I'll need to see an ISA-Tab where this fails to determine whether we need to change something or if the ISA-Tab should be modeled differently.

mikkonie commented 1 month ago

The sample sheet in question provides file material name fields as simple links, which SODAR does not currently support. So this becomes a design question on whether we should support this, add functionality for that and increase the max length, or instruct users to link to files using assay plugins or provide links in other fields. Marking this issue tbd for now.