search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Allow modifying user membership if project is locked by taskflow #1948

Closed mikkonie closed 2 weeks ago

mikkonie commented 3 weeks ago

A user noted that while a project is locked by taskflowbackend during e.g. landing zone validation or moving, adding new members in the project fails.

Technically, there should not be a reason for us to require locking the project here, as we're simply modifying user group membership with ACLs, nothing to do with e.g. sample data collections directly.

Hence, we should simply be able to allow role updates and deletes by setting require_lock=False in the related flows.

This has to be properly tested of course.

mikkonie commented 2 weeks ago

I noticed we don't really test for running flows with locked projects. Setting up these tests should be trivial, so I'll go ahead and do it while fixing this issue.

mikkonie commented 2 weeks ago

Done.