search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

TaskflowAPI._raise_flow_exception() crash when setting longer status than allowed by model #1953

Closed mikkonie closed 2 weeks ago

mikkonie commented 2 weeks ago

Something I noticed while writing tests for #1948. There is a limit for status length in the LandingZone model, but _raise_flow_exception() does not follow that.

This, or similar behaviour elsewhere in code, MAY be the root cause for #1458 and/or #1894. I'll have to look into it further.

I will also have to rethink the implementation of the maximum status length. Maybe allow for maximum db value in model, truncate when displaying? The status updating is to be revamped anyway, see e.g. #1614.

For now, this obvious bug should be fixed.

mikkonie commented 2 weeks ago

Fixed.