bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Add custom ISA-Tab template uploader app #1961

Closed mikkonie closed 3 months ago

mikkonie commented 4 months ago

There has been discussion lately about the possibility of uploading custom ISA-Tab templates into SODAR. Currently, templates are hard-coded to being imported from the cubi-isa-templates respository. Short of forking SODAR and replacing the dependency with one's own template repository, uploading custom templates is not currently supported.

In the long term, we will probably look into moving away from Cookiecutter templates altogether. However, this is not currently in the roadmap. In the short term, I would propose adding a simple app to upload/manage custom sample sheets. Proposed spec below.

Spec

With this spec I'd expect this to take some 2-3 days to implement, including testing.

TBD: Prioritization/milestone. Comments are welcome.

tbrittoborges commented 4 months ago

Just to re-iterate, this feature would be super important for us here in the Heidelberg University Hospital because we're keeping a separate fork for SODAR-SERVER and cubi-isa-templates only to have our own templates. This may be problematic on the long rung.

mikkonie commented 3 months ago

Done. This app is still rather rudimentary and doesn't have any in-line editing, REST API or such. Further features can be developed in the future of course and I'm always happy to review pull requests :)

tbrittoborges commented 3 months ago

Thank you for providing us with this feature @mikkonie, we will deploy it to our test server and test it.

mikkonie commented 3 months ago

Thank you for providing us with this feature @mikkonie, we will deploy it to our test server and test it.

I hope you'll find it useful @tbrittoborges! It's now also in the latest release v0.15.0 on the main branch. Feel free to open tickets (and possibly submit pull reguests) if you find issues.