search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Generic assay plugin: Inline links in material columns always point to ResultsReports #1982

Closed sellth closed 2 months ago

sellth commented 3 months ago

In this example:

Comment[SODAR Assay Link Results]   Standardized Analysis Report
Comment[SODAR Assay Link Row]   Raw Data File;Report File

Raw Data File columns will link to Results & Reports when they should be pointing at the RowPath. This behaviour is consistent for all Data and Material headers.

sellth commented 3 months ago

There's a check for target_cols missing here: https://github.com/bihealth/sodar-server/blob/da733149560ed74dc4dc3d3f5565d9c0418dbc60/samplesheets/assayapps/generic/plugins.py#L66-L72

mikkonie commented 2 months ago

Fixed by @sellth, closed.