search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Add SODAR auth support for study plugin IGV session file serving views #2020

Closed mikkonie closed 1 month ago

mikkonie commented 1 month ago

It appears this is something we overlooked when we implemented the SODAR auth view. While iRODS auth can be handled via the view, the basic auth for the IGV session file serving views does not pass through the same auth. Hence, only LDAP/AD users can access files served by these views.

This has never been reported, probably because this view was mainly used for evaluating the system in a local docker env. Alas, with #1999 this will be required for OIDC users as well.

Hence, the possibility to auth against SODAR directly should be enabled for these views.

I should also looking into moving the view (or at least a related base view/mixin) out of the irodsbackend app, as this feature does not only concern iRODS anymore.

mikkonie commented 1 month ago

It's also possible this has not been reported because it actually already works. The auth is done regardless of local/LDAP status. I should have reviewed the implementation before opening a ticket..

The part about adding token auth for these views in #1999 is still very much valid though.