search

bihealth / sodar-server

SODAR: System for Omics Data Access and Retrieval
https://github.com/bihealth/sodar-server
MIT License
14 stars 3 forks source link

Add clearer message to sign-in request for WebDAV #2030

Open Nicolai-vKuegelgen opened 1 month ago

Nicolai-vKuegelgen commented 1 month ago

Problem

When using the (sometimes very helpful) links to view collection files via WebDAV, there is usually an additional sign-in request from the WebDAV/davrods server. Currently (firefox 131, ubuntu), this request is pop-box with the following information:

sodar.bihealth.org This site is asking you to sign in. Username: [ ] Password: [ ]

Especially for users not very familiar with Sodar this, seemingly unprompted, sign-in request might be very confusing.

Solution

The popup box should convey additonall information, including the need to add '@ORG' to the username. I.e.:

sodar.bihealth.org Browsing files via WebDAv requires a separate login. Please use the same username & password you use for Sodar. Username: [ @ CHARITE ] Password: [ ]

mikkonie commented 1 month ago

As far as I understand, this should be controllable by the DAVRODS_AUTH_NAME env variable provided to davrods-docker. Looking at our Ansible playbook, we in fact have already defined more descriptive login messages there. Why they are currently not showing up, I don't know. I'll look into it.

In any case, this is a ticket for either the Davrods repo or our internal deployment repo, as the SODAR server package does not control login messages for external sites. The exception for this being IGV sessions, which are of course served directly through the Django server.

Still, as this is a valid concern, I'll leave this ticket open until the issue has been handled in the respective components.

It should also be noted that the message should take in account OIDC users if deploying an instance where OIDC is enabled, as a different method of logging in is required for them.