General samplesheets Vue.js app cleanup

mikkonie commented 5 years ago

Will collect some minor refactoring points I've picked up during development.

Needs proper testing (see #750)

[ ] Use includes() instead of the old-fashioned indexOf() when looking for substrings
[ ] Use bootstrap-vue elements instead of "hard coded" html/classes where applicable
[x] Use getGridOptionsByUuid() and similar helpers in all components
[ ] Figure out why this.$forceUpdate() is required in the current modal data filtering method even when we use this.$set() to modify component data
[ ] Use simplified data () {} notation
[x] Unify member notations (.x vs ['x'])
[ ] No need to have "ref" in reference names
[ ] Remove redundant != null comparisons

mikkonie commented 4 years ago

marked the task Use getGridOptionsByUuid() and similar helpers in all components as completed

mikkonie commented 4 years ago

marked the task Unify member notations (.x vs ['x']) as completed

mikkonie commented 4 years ago

mentioned in commit 7dc65e652695572bca59612c31251b39a1d7effc

mikkonie commented 4 years ago

mentioned in commit 01cde1b672373d6c5e895f643bdd591a49e70d48

mikkonie commented 4 years ago

mentioned in commit 4572f8fb6c610f400f69bccf10625d9979ae540e

bihealth / sodar-server