search

biolink / ontobio

python library for working with ontologies and ontology associations
https://ontobio.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
119 stars 30 forks source link

Association collections #485

Closed dougli1sqrd closed 3 years ago

dougli1sqrd commented 3 years ago

This is the bit that will help thread through arbitrary Annotation data along with Bio Entity data. Drawing when the three of us talked about this: https://docs.google.com/drawings/d/1QSurx_SG50LXUpVRUYZVWNkSF8szGrGh5DpBtXRzKGo/edit

kltm commented 3 years ago

Excitement!

dustine32 commented 3 years ago

@dougli1sqrd Oh right, I suppose the same code change could apply to master right now. Should I make a separate branch and PR to master for this?

dougli1sqrd commented 3 years ago

Yeah I imagine we should. This could show up in the current world now, so let's separate it out.

dougli1sqrd commented 3 years ago

Okay, this is a real PR now!

kltm commented 3 years ago

@dougli1sqrd What does the "risk profile" look like to you? Should this go in before the next release attempt?

dougli1sqrd commented 3 years ago

Low risk, but we should probably go ahead and wait for the release to make an ontobio release and bump go-site. I think we'd be safe to merge to master though.

kltm commented 3 years ago

What he sez.