ontobio validate.py should not grab the "compression" value from the dataset metadata without guards

biolink / ontobio

python library for working with ontologies and ontology associations

https://ontobio.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

119 stars 30 forks source link

ontobio validate.py should not grab the "compression" value from the dataset metadata without guards #496

Open dougli1sqrd opened 3 years ago

dougli1sqrd commented 3 years ago

Line 138 of validate.py we have dataset_metadata["compression"] == "gzip" when grabbing compression info for a dataset source.

If the compression field is not present -- which is valid by the schema -- should just act as empty. Additionally we should ensure that an empty value for compression correctly acts as "empty" or false when being investigated.