Issue 544 rulesets - Githubissues

biolink / ontobio

python library for working with ontologies and ontology associations

https://ontobio.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

119 stars 30 forks source link

Issue 544 rulesets #545

Closed dougli1sqrd closed 3 years ago

dougli1sqrd commented 3 years ago

For https://github.com/biolink/ontobio/issues/544

kltm commented 3 years ago

Looks good to me so far. Is the idea that if you declare rules, but don't specify, they all run, or does one need to be explicit? I'll leave it to @dustine32 to do final review and merge.

dougli1sqrd commented 3 years ago

Yeah, in ontobio-parse-assocs if no rules are specified, then none are run. You can pass in the string "all" to set all the rules, otherwise, it just uses whatever set you pass in via repeated -l <N>

kltm commented 3 years ago

Okay--sounds good. Looks good to me.