search

biolink / ontobio

python library for working with ontologies and ontology associations
https://ontobio.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
119 stars 30 forks source link

Emit providedBy to all individuals; for geneontology/gocamgen#89 #552

Closed dustine32 closed 3 years ago

dustine32 commented 3 years ago

Fixes an issue where "Assigned By" isn't appearing for MOD import annotations in ART or Noctua Form.

kltm commented 3 years ago

Single to list, looks good to me. In general, are there tests for these kinds of things?

kltm commented 3 years ago

@dustine32 Cannot link through to issue through title geneontology/gocamgen#89

dustine32 commented 3 years ago

@kltm Thanks for fixing the link, I forgot it won't do it automatically through the title.

For tests, I used to have them for things like this on the old gocamgen repo, where I made the model in rdflib.graph and then SPARQL'ed out what I was looking for. But the startup cost for generating a model has become >10 sec. Maybe I can strip down the process a bit.

kltm commented 3 years ago

Something to pick at anyways at some point. Or something. I'm not sure if you actually want feedback from both of us; feel free to merge.