search

biolink / ontobio

python library for working with ontologies and ontology associations
https://ontobio.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
118 stars 30 forks source link

Ignore GORULE:0000028 aspect check when parsing GPAD #619

Closed dustine32 closed 2 years ago

dustine32 commented 2 years ago

Fixes geneontology/pipeline#280.

Specifically, the aspect rule test (GORULE:0000028) will still run for GPAD and repair the empty GoAssociation.aspect (this is how aspect is sourced when merging noctua_{group}.gpad into {group}.gaf) but the reports will no longer reflect failure.

dustine32 commented 2 years ago

I also had to add the taxon_map=False param to the golr_search_query test to get it to pass. This bypasses some new code from #618 that expects updated test data to be added to tests/unit/resources/solr/input/solr-docs.json (e.g. results.facets['facet_pivot']['taxon,taxon_label'])

Tagging @falquaddoomi in case they want to update this test data themselves.

kltm commented 2 years ago

@dustine32 I'm not sure if you still need to coordinate this with others, but it's fine by me.