biolink / ontobio

python library for working with ontologies and ontology associations
https://ontobio.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
119 stars 30 forks source link

For #2093 #653

Closed mugitty closed 11 months ago

mugitty commented 11 months ago

@pgaudet has made some changes to the requirements. I have to made additional changes. I will let you know when it is ready for review.

Thanks

kltm commented 11 months ago

@mugitty The user you want is: @pgaudet, not "Paudet"

kltm commented 11 months ago

@mugitty Updating your comment

mugitty commented 11 months ago

The code is ready for review, I have updated for the new requirements.

kltm commented 11 months ago

For geneontology/go-site#2093 -- to create link

dustine32 commented 11 months ago

@mugitty Is this the ontobio change needed to update go-site's Makefile-gaf-reprocess to be used in the GO pipeline's "Temporary post filter" step? Sorry if I'm mixing this up with a slack convo we had last Thurs.

dustine32 commented 11 months ago

@mugitty I'm mainly concerned with finding the correct ontobio-parse-assocs.py command that we should be testing for this.

mugitty commented 11 months ago

@dustine32 - You are correct. The update in required for Makefile-gaf-reprocess .

You can review from https://github.com/geneontology/go-site/pull/2127