Go site 2246 gorule 0000001 rnac rna types are getting mangled

biolink / ontobio

python library for working with ontologies and ontology associations

https://ontobio.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

118 stars 30 forks source link

Go site 2246 gorule 0000001 rnac rna types are getting mangled #676

Closed mugitty closed 3 weeks ago

kltm commented 3 weeks ago

Noting geneontology/go-site#2246

kltm commented 3 weeks ago

@mugitty Should I wait until the tests pass for review?

mugitty commented 3 weeks ago

@mugitty Should I wait until the tests pass for review?

Please wait until tests pass

dustine32 commented 3 weeks ago

@mugitty Cool, looks like you fixed the tests! That failing tests/unit/test_clinical_mod.py test was removed from travis_test on master a few months ago so definitely wasn't your code's fault.

mugitty commented 3 weeks ago

@dustine32, I had to merge the updates from master

Thanks

mugitty commented 3 weeks ago

@kltm and @dustine32 I have updated the CURIE lookup table with latest updates requested by @pgaudet and restored previous updates to tests. Please review

pgaudet commented 3 weeks ago

Great! Can we now have a list of the entity types that fail ? (ideally by group - ie 'assigned by')