Open eikowagenknecht opened 6 months ago
@nhedger
Is it expected that the extension copies the executable to the temporary directory?
Biome binary found at c:\*****\*****\*****\node_modules\@biomejs\cli-win32-x64\biome.exe
Copying binary to temporary folder: file:///c%3A/Users/*****/AppData/Roaming/Code/User/workspaceStorage/27cd3cb02ff8195e374488eb4166ba68/biomejs.biome/biome.exe
Executing Biome from: c:\Users\*****\AppData\Roaming\Code\User\workspaceStorage\27cd3cb02ff8195e374488eb4166ba68\biomejs.biome\biome.exe
Yes. We do that to prevent locking the binary in the project’s dependencies which prevents users from upgrading biome with their package manager if the server has been started. This is typically an issue we witnessed on windows.
Running Biome in a completely fresh VS Code (portable) it seems to be better now. But I noticed that I can still regularly get Biome to crash by running npm i ...
or anything else that modifies the package.json
/ package-lock.json
.
Unusable for me in VS Code Insiders 1.90.0-insider on Mac Ventura 13.6.6 (M1), and earlier versions.
Example of output:
Could not resolve Biome in the dependencies of workspace folder: /Users/me/src/myproj
Searching for Biome in PATH
Biome binary found at /Users/me/Library/Application Support/Code - Insiders/User/globalStorage/biomejs.biome/server/biome
Executing Biome from: /Users/me/Library/Application Support/Code - Insiders/User/globalStorage/biomejs.biome/server/biome
[cli-stderr] end
[cli-stdout] end
[cli] exit null
[Error - 2:56:53 PM] Biome client: couldn't create connection to server.
Environment information
What happened?
Biome regularly crashes in VS Code. More often than not I see this little popup:
Logs from the "Biome" Output:
Logs from biome-logs folder:
biome-log.txt
Expected result
It should not crash.
Code of Conduct