search

biomejs / biome

A toolchain for web projects, aimed to provide functionalities to maintain them. Biome offers formatter and linter, usable via CLI and LSP.
https://biomejs.dev
Apache License 2.0
14.61k stars 457 forks source link

📎 Refactor/fix `JsParserSettings` for better override behavior #3297

Open dyc3 opened 3 months ago

dyc3 commented 3 months ago

Description

We've recently found that overrides specified in configuration caused json parser settings to be overwritten, even when the override didn't specify those options. Found in #3260, fixed in #3272, see also #3273.

This task is to investigate and fix any similar issues for JsParserSettings.

Conaclos commented 3 months ago

See also #3183

We have a similar issue with jsxRuntime.

Sec-ant commented 3 months ago

I created #3317 @dyc3, I think it already addressed this issue. But there's a bigger refactoring task behind. Feel free to get involved. There're some discussions at https://github.com/biomejs/biome/pull/3310

Conaclos commented 2 months ago

Is this issue addressed by #3317?

Sec-ant commented 2 months ago

Is this issue addressed by #3317?

It will be, but given the scope of the refactoring, addressing merge conflicts has become more and more difficult with scattered commits, so I squashed all the commits. And that PR is not ready to be merged yet because I can't find time to work on it recently.