biomejs / biome

A toolchain for web projects, aimed to provide functionalities to maintain them. Biome offers formatter and linter, usable via CLI and LSP.
https://biomejs.dev
Apache License 2.0
15.46k stars 481 forks source link

🐛 `extends` using extenal packages not working with Yarn PnP #3391

Closed NedcloarBR closed 4 months ago

NedcloarBR commented 4 months ago

Environment information

CLI:
  Version:                      1.8.3
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.6.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "yarn/4.3.1"

Biome Configuration:
  Status:                       Failed to load
  Error:                        Failed to resolve the configuration from /home/nedcloarbr/Projetos/nestjs-template

Workspace:
  Open Documents:               0

What happened?

I've created a package(@nedcloarbr/biome-config) that stores my biome settings. At the moment I'm updating/creating project templates, but when setting up a template that uses Yarn PnP, the package configuration file is not found by the biome. If I configure yarn's nodeLinker to node-modules, the configuration is created, but in this template I need to use PnP to save space.

Playground

Expected result

It should find the config from external package when using Yarn PnP.

Code of Conduct

ematipico commented 4 months ago

This is a non-goal for now

NedcloarBR commented 4 months ago

So I'll have to use nodeLinker: node-modules at the moment Is there a roadmap containing this fix?

ematipico commented 4 months ago

@NedcloarBR this is a non-goal, not a bug. We don't plan to support PNP for the time being.

Feel free to open a discussion if you want to propose it.

NedcloarBR commented 4 months ago

Okay thanks!