search

biosimulations / biosimulations-physiome

Command-line application for publishing the Physiome model repository of physiological models to the BioSimulations repository for simulation projects
https://docs.biosimulations.org/repositories/physiome
0 stars 0 forks source link

Remove COMBINE archives nested in archives #15

Closed jonrkarr closed 2 years ago

jonrkarr commented 2 years ago

Either

(a) Remove COMBINE archives nested in archives

OR

(b) Replace http://purl.org/NET/mediatypes/None with http://identifiers.org/combine.specifications/omex

Example: https://github.com/biosimulations/biosimulations-physiome/blob/dev/projects/5f3/omexContents/manifest.xml#L5

bilalshaikh42 commented 2 years ago

This should no longer be an issue since we are generating our own combine archives

jonrkarr commented 2 years ago

@bilalshaikh42 are you excluding files with extension .omex or format http://identifiers.org/combine.specifications/omex from the archives that you generate? or correcting their formats in manifests?

bilalshaikh42 commented 2 years ago

The current code would end up just including them with the correct filetype. I could also exclude them If that makes more sense

On Wed, Jan 5, 2022, 6:07 PM Jonathan Karr @.***> wrote:

@bilalshaikh42 https://github.com/bilalshaikh42 are you excluding files with extension .omex or format http://identifiers.org/combine.specifications/omex from the archives that you generate?

— Reply to this email directly, view it on GitHub https://github.com/biosimulations/biosimulations-physiome/issues/15#issuecomment-1006147740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHX4FIBX6QDQNZJO2WKC5GTUUTFJZANCNFSM5KOT4F5Q . You are receiving this because you were mentioned.Message ID: @.***>

jonrkarr commented 2 years ago

That sounds good: