search

bisq-network / roles

@bisq-network contributor roles
https://bisq.wiki/Roles
15 stars 16 forks source link

Bisq Maintainer #63

Open cbeams opened 6 years ago

cbeams commented 6 years ago

Docs: https://bisq.wiki/Bisq_Maintainer Team: @bisq-network/bisq-maintainers

cbeams commented 6 years ago

I've assigned @ripcurlx to this role, reflecting the work that he is already doing on Bisq's UI. This is still a role that we'd like additional developers to take on, though. There is plenty of work to be done!

cbeams commented 6 years ago

I've renamed this role from JavaFX Developer => Bisq Desktop Maintainer. @ripcurlx, as the primary role owner here, please report monthly as you see fit.

ripcurlx commented 6 years ago

2018.05 report

Reviewing and merging of PRs and release preparations for v0.7.0

/cc https://github.com/bisq-network/compensation/issues/71

ripcurlx commented 6 years ago

2018.06 report

Reviewing and merging of PRs and release preparations for v0.7.1

/cc bisq-network/compensation#84

cbeams commented 6 years ago

2018.06 report

Nothing to report. Note that I plan to remove myself from the set of desktop maintainers.

/cc bisq-network/compensation#89

cbeams commented 6 years ago

@ripcurlx wrote

Reviewing and merging of PRs

I think it's important that we account separately for maintainer work and PR review work. I've written about this in the WIP Roles doc, see https://deploy-preview-46--bisq-docs.netlify.com/roles.html#maintainer. I'm +1'ing your compensation request as-is, but something to keep in mind as you review that doc.

cbeams commented 6 years ago

I've updated the @bisq-network/desktop-maintainers team and the description of this issue to reflect that @ManfredKarrer and @ripcurlx are Bisq Desktop maintainers now, and that I've removed myself.

ripcurlx commented 6 years ago

@cbeams Regarding PR reviewer work. Should this be part of the general contributions delivered section in a compensation request referencing PRs reviewed?

cbeams commented 6 years ago

@ripcurlx wrote:

Regarding PR reviewer work. Should this be part of the general contributions delivered section in a compensation request referencing PRs reviewed?

Yes. Please see the new https://docs.bisq.network/roles.html#maintainer-duties and https://docs.bisq.network/roles.html#compensation documentation, and provide any feedback in the related proposal at https://github.com/bisq-network/proposals/issues/30, thanks.

ripcurlx commented 5 years ago

2018.07 report

Release of v0.7.1

/cc bisq-network/compensation#98

ripcurlx commented 5 years ago

2018.08 report

Release of v0.8.0

/cc bisq-network/compensation#109

cbeams commented 5 years ago

Renamed to "Bisq Maintainer" to reflect the monorepo reconsolidation in bisq-network/bisq#1650 and added @cbeams as a member of @bisq-network/bisq-maintainers (which has also been renamed) to reflect his maintainer role over the assets subproject.

ripcurlx commented 5 years ago

2018.09 report

This month we reconsolidated all code repositories into one mono repo to make it easier for developers to work across modules and switched to Java 10. No release this month.

/cc bisq-network/compensation#126

ripcurlx commented 5 years ago

2018.10 report

We've created a release branch for 0.9.0 this time before merging to master to make it easier to cooperate and developer test the work happening in the redesign and DAO in parallel.

/cc bisq-network/compensation#148

ripcurlx commented 5 years ago

2018.11 report

We've been working on and syncing the release branch for 0.9.0 to make it easier to cooperate and developer test the work happening in the redesign and DAO in parallel. This month also release preparations and testing for v0.9.0 is part of my Desktop Maintainer contribution.

/cc bisq-network/compensation#177

ripcurlx commented 5 years ago

2018.12 report

We had a busy December with two releases (v0.9.0 and v0.9.1). Release preparations and testing is part of my Desktop Maintainer contribution this month.

/cc bisq-network/compensation#195

ripcurlx commented 5 years ago

2019.01 report

We had again a busy month with two releases (v0.9.2 and v0.9.3). We also added the stale app to help cleaning up our issue repository. It will mark issues that are inactive for 90 days as stale and close it without activity 7 days later. Excluded from becoming stale are issues with following labels:

Release preparations and testing is part of my Desktop Maintainer contribution this month.

/cc bisq-network/compensation#206

ripcurlx commented 5 years ago

2019.02 report

We released v0.9.4. Release preparations and testing is part of my Desktop Maintainer contribution this month.

/cc bisq-network/compensation#224

ripcurlx commented 5 years ago

2019.03 report

We released v0.9.5. Release preparations and testing is part of my Desktop Maintainer contribution this month.

/cc bisq-network/compensation#247

ripcurlx commented 5 years ago

2019.04 report

We released v1.0.0 and v1.0.1. Release preparations and testing is part of my Desktop Maintainer contribution this month.

/cc bisq-network/compensation#269

sqrrm commented 5 years ago

Cycle 2 report

Took over as secondary Bisq maintainer. I have merged PRs and done minor git admin.

https://github.com/bisq-network/compensation/issues/293

ripcurlx commented 5 years ago

Cycle 2 report

We released v1.1.2.

Release preparations and testing is part of my Desktop Maintainer contribution for this cycle.

ripcurlx commented 5 years ago

Cycle 3 report

No release this cycle as we are still working on the account signing feature. Probably we'll release one more version before this feature as a couple of PRs already piled up.

sqrrm commented 5 years ago

Cycle 3 report

All maintainer work is included under other posts for compensation, as appropriate.

https://github.com/bisq-network/compensation/issues/311

bisq-github-admin-3 commented 5 years ago

I just added @freimair as a Bisq maintainer to increase the issue and PR throughput.

sqrrm commented 4 years ago

Cycle 4 report

All maintainer work is included under other posts for compensation, as appropriate.

@ripcurlx handled releases, helped with testing and preparation.

bisq-network/compensation#325

ripcurlx commented 4 years ago

Cycle 4 report

We released v1.1.3 and v1.1.4.

Release preparations and testing is part of my Desktop Maintainer contribution for this cycle.

/cc https://github.com/bisq-network/compensation/issues/269

ripcurlx commented 4 years ago

Cycle 5 report

We released v1.1.5.

Release preparations and testing is part of my Desktop Maintainer contribution for this cycle.

/cc https://github.com/bisq-network/compensation/issues/269

sqrrm commented 4 years ago

Cycle 5 report

All maintainer work is included under other posts for compensation, as appropriate.

Didn't help much with the latest release, thanks to @ripcurlx for all the work

https://github.com/bisq-network/compensation/issues/356

ripcurlx commented 4 years ago

Cycle 6 report

We released v1.1.6 and v1.1.7.

Release preparations and testing is part of my Desktop Maintainer contribution for this cycle.

/cc https://github.com/bisq-network/compensation/issues/369

sqrrm commented 4 years ago

Cycle 6 report

All maintainer work is included under other posts for compensation, as appropriate.

The other maintainers have taken most of the work this month

https://github.com/bisq-network/compensation/issues/375

ripcurlx commented 4 years ago

Cycle 7 report

We released v1.2.0, v1.2.1, v1.2.2 and v1.2.3.

Release preparations and testing is part of my Desktop Maintainer contribution for this cycle.

/cc https://github.com/bisq-network/compensation/issues/401

sqrrm commented 4 years ago

Cycle 7 report

All related work, such as merges and release preparation, has been documented elsewhere,

https://github.com/bisq-network/compensation/issues/403

ripcurlx commented 4 years ago

Cycle 8 report

We released v1.2.4.

Release preparations is part of my Desktop Maintainer contribution for this cycle.

/cc https://github.com/bisq-network/compensation/issues/439

sqrrm commented 4 years ago

Cycle 8 report

Not much done, been away. Some merges and didn't help with the release.

bisq-network/compensation#441

sqrrm commented 4 years ago

Cycle 9 report

Quite a bit of work on reviews and merges, as documented in the compensation request.

Helped out with release testing.

bisq-network/compensation#461

ripcurlx commented 4 years ago

Cycle 9 report

We released v1.2.5.

Release preparations is part of my Desktop Maintainer contribution for this cycle.

/cc https://github.com/bisq-network/compensation/issues/466

sqrrm commented 4 years ago

Cycle 10 report

Things have changed a bit with the new stricter structure stewarded by strongman Chris (really would've been better had it been Steve for my alliteration). We're trying to focus the reviews on prioritized work. Less fluff all around, only place left for fluffy fearless phrasing is the Bisq maintainer report.

bisq-network/compensation#488

ripcurlx commented 4 years ago

Cycle 10 report

So much peer pressure by role peers to create more fluffy fearless phasing this time. Unfortunately not part of the Austrian mentality, so no fluff for me this time 😜

We released v1.2.6. To reduce unnecessary review time I've added Codacy now to the Bisq repository as well. It enforces certain development guidelines and will be adapted over time until a PR review will only be about the code changed and not about the lack of formatting, unused imports or similar stuff.

Release preparations are NOT part of my Desktop Maintainer contribution for this cycle, as I'll add it separately to the compensation request to improve transparency.

/cc https://github.com/bisq-network/compensation/issues/493

sqrrm commented 4 years ago

Cycle 12 report

Some introspection is warranted after the failures of reviews regarding the recent security issues. I see it as a failure of all parts of the Bisq DAO, and for this role it would be in the review letting this kind of issue slip through. Should we spend more time on reviews? Is there just a lack of eyes on code being merged? Do we have a structural flaw or just an issue of execution?

After we have a post mortem a discussion around these questions and much more would be useful.

https://github.com/bisq-network/compensation/issues/536

ripcurlx commented 4 years ago

Cycle 12 report

We released v1.2.9, v1.3.0 and v1.3.1. I do agree with @sqrrm that we need to do a proper review why this security vulnerability happened and how we can prevent it in the future. Also our release, hotfix release cadence needs to be ended. We are trying something out already for v1.3.2, but it needs to be tested, formalized and properly executed from now on.

/cc https://github.com/bisq-network/compensation/issues/542

sqrrm commented 4 years ago

Cycle 13 report

I've taken over the admin duties that @ripcurlx usually handle. Acking CRs, more vigilant eye on PRs (which I should be doing anyway, but haven't been great at) and trying to keep the dev priorities in order. While I'm not excelling I'm spending an inordinate amount of time on stuff, just stuff. Hope for a swift return of @ripcurlx to handle things more efficiently.

bisq-network/compensation#564

sqrrm commented 4 years ago

Cycle 14 report

Spent more time on PR overview, meetings and planning than my normal schedule. @ripcurlx will likely be back next week, very good news indeed.

bisq-network/compensation#597

sqrrm commented 3 years ago

Cycle 15 report

Didn't do much specific maintaining. Still doing reviews but not as much admin.

https://github.com/bisq-network/compensation/issues/623

ripcurlx commented 3 years ago

Cycle 13 -15 report

We released v1.3.2, v1.3.3, v1.3.4, v1.3.5 and v1.3.6.

@sqrrm Took over this role mainly for cycle 13 and 14 and I only did the bare minimum during that time (Thanks!). In cycle 15 I took again over the role and am still trying to catch up with everything that stacked up during that time. Still there is light at the end of the tunnel and we started to re-pay victims by the BTC fees and continue to ship great additions to the Bisq client.

/cc https://github.com/bisq-network/compensation/issues/625

ripcurlx commented 3 years ago

Cycle 16 report

We released v1.3.7.

/cc https://github.com/bisq-network/compensation/issues/652

sqrrm commented 3 years ago

Cycle 16 report

Been a bit more with reviews and other admin details this month. Hope to see codacy in reasonable shape eventually

bisq-network/compensation#646

sqrrm commented 3 years ago

Cycle 17 report

A lot of activity this month. Many merge issues due to Codacy. It's a pity that it might be causing more trouble than benefit. I'm suggesting that we disable the enforced pass to allow merging when we don't like what it's saying.

https://github.com/bisq-network/compensation/issues/667

ripcurlx commented 3 years ago

A lot of activity this month. Many merge issues due to Codacy. It's a pity that it might be causing more trouble than benefit. I'm suggesting that we disable the enforced pass to allow merging when we don't like what it's saying.

bisq-network/compensation#667

I agree that it caused troubles in the past, but I think it is mainly a matter of configuration and tuning until it works as we want it to be. But yes, we can remove the enforced pass to allow merging until we have reached that point.

Bildschirmfoto 2020-09-22 um 15 38 10

Actually it does seem to be configured that way already.

ripcurlx commented 3 years ago

Cycle 17 report

We pre-released v1.3.8 and publicly released v1.3.9.

/cc https://github.com/bisq-network/compensation/issues/671