bit-bots / bitbots_main

This git contains all RoboCup code from the Hamburg Bit-Bots.

https://bit-bots.de

MIT License

30 stars 11 forks source link

Small dynup refactoring #505

Closed Flova closed 1 week ago

Flova commented 1 week ago

Summary

Fix memory management issues
Use dict for dynup goal
Fix init values
Format parameter yaml
Remove PID nodes

Proposed changes

This mainly touches up minor issues, memory management and internal representation. The overall algorithm is left unchanged.

Related issues

Closes #300 Closes #308

Checklist

[x] Run colcon build
[x] Write documentation
[x] Test on your machine
[ ] Test on the robot
[ ] Create issues for future work
[x] Triage this PR and label it

Flova commented 1 week ago

only did a quick readover but lgtm I would not call it a "small" refactor if there are >800 lines changed 😆

Yeah it escalated a bit, but I didn't really touch the core functionality and 400+ of it was just config formatting. Today is feature freeze and I wanted to wrap things up, sry 😅

Flova commented 1 week ago

But thanks for the speedy review!