bitcraze / crazyflie-lib-python

Python library to communicate with Crazyflie
Other
253 stars 889 forks source link

Replace reset estimator in non-swarm examples #323

Open knmcguire opened 2 years ago

knmcguire commented 2 years ago

The reset estimator has been converted for all swarm examples to a cflib function but not for the regular single drone examples...

It would improve the cleanliness of all the examples, but might compromise the backward compatiblity that #288 was experiencing.

diegoch-it commented 2 months ago

@knmcguire These are the examples to be modified (by folder):

In autonomy: -autonomousSequence.py -autonomous_sequence_high_level.py -autonomous_sequence_high_level_compressed.py -circling_square_demo.py -full_state_setpoint_demo.py

In lighthouse -lighthouse_openvr_grab.py -lighthouse_openvr_grab_color.py -lighthouse_openvr_multigrab.py

In mocap -mocap_hl_commander.py -qualisys_hl_commander.py

In positioning -flowsequenceSync.py -initial_position.py

The function to be created in SyncCrazyflie class and replaced in the examples are: -reset_estimator() -wait_for_position_estimator()

Should I create a pull request for each example?

knmcguire commented 2 months ago

absolutely! Make sure to test it out though on at least one :) Thanks!