search

bitwalker / exprotobuf

Protocol Buffers in Elixir made easy!
Apache License 2.0
486 stars 69 forks source link

fixed string decoding (inside oneof) #74

Closed amatalai closed 7 years ago

amatalai commented 7 years ago

As far as I remember repeated can't be used inside oneof, so only list we can get inside oneof is character list (string field).

71

bitwalker commented 7 years ago

Just to be sure, can you find the reference for this restriction in the spec? I'm happy to merge this, just don't want to do it if it breaks things unexpectedly.

amatalai commented 7 years ago

Yup, here it is:

https://developers.google.com/protocol-buffers/docs/proto#oneof

You then add your oneof fields to the oneof definition. You can add fields of any type, but cannot use the required, optional, or repeated keywords.

bitwalker commented 7 years ago

Thanks!

bitwalker commented 7 years ago

I'll get a new release published today hopefully