bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.51k stars 817 forks source link

App Crash on iOS 15 Beta 5 #1493

Closed sso-bitwarden closed 3 years ago

sso-bitwarden commented 3 years ago

I am able to log in. Regardless of whether or not I make any changes to the settings (enable FaceID or not, change timeouts, etc.) the app will immediately close out as soon as I reopen the app. An ips is generated and the stack racestarts with (if it helps):

"exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"}, "asi" : {"libsystem_c.dylib":["abort() called"]}, "lastExceptionBacktrace" : [{"imageOffset":628456,"imageIndex":5},{"imageOffset":89956,"imageIndex":6},{"imageOffset":1532244,"imageIndex":5},{"imageOffset":188548,"imageIndex":5},{"imageOffset":184768,"imageIndex":5},{"imageOffset":1792184,"imageIndex":11},{"imageOffset":767644,"imageIndex":5},{"imageOffset":836336,"imageIndex":5},{"imageOffset":23652,"imageIndex":5},{"imageOffset":46084,"imageIndex":5},{"imageOffset":126920,"imageIndex":5},{"imageOffset":5004,"imageIndex":8},{"imageOffset":5340688,"imageIndex":9},{"imageOffset":2713072,"imageIndex":9},{"imageOffset":5973944,"imageIndex":3},{"imageOffset":5262784,"imageIndex":3},{"imageOffset":5262660,"imageIndex":3},{"imageOffset":595272,"imageIndex":3},{"imageOffset":4415840,"imageIndex":3},{"imageOffset":284552,"imageIndex":4},{"imageOffset":1055304,"imageIndex":4},{"imageOffset":1080480,"imageIndex":4},{"imageOffset":143556,"imageIndex":4},{"imageOffset":34310384,"imageIndex":3},{"imageOffset":595088,"imageIndex":3},{"imageOffset":105252,"imageIndex":10}], "faultingThread" : 0, "threads" : [{"triggered":true,"id":371738,"threadState":{"x":[{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":10000000},{"value":5120},{"value":18446744069414586880},{"value":9007292605623196026},{"value":9007292609895505146},{"value":1000},{"value":12532993},{"value":16393},{"value":4763844608},{"value":16383},{"value":33922},{"value":328},{"value":4345218432},{"value":0},{"value":6},{"value":259},{"value":4345218656},{"value":4749022304},{"value":4764860752},{"value":4763726336},{"value":4379446488},{"value":4764860928},{"value":5},{"value":4309885279}],"flavor":"ARM_THREAD_STATE64","lr":{"value":8390571060},"cpsr":{"value":1073741824},"fp":{"value":6161400176},"sp":{"value":6161400144},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":7425071544,"matchesCrashFrame":1},"far":{"value":6165807040}},"name":"tid_103","queue":"com.apple.main-thread","frames":[{"imageOffset":31160,"imageIndex":0},{"imageOffset":29748,"imageIndex":1},

Environment

jerryc127 commented 3 years ago

yes. I update to iOS 15 beta 5 The app cannot open when click the icon directly but it can use to fill in the password with keyboard

the-great-emu-kerfuffle commented 3 years ago

I am the reporter of this bug. More info of questionable quality: If I leave the app running, and do not force close, I can continue to access the app with no issues. If I close it, I have to uninstall & reinstall and then reauthenticate to use it. Also, I can offload the app and reinstall and it will work, which is quicker.

I will need to see if the problem exists on the latest iPadOS beta.

I’m willing to assist in troubleshooting or providing more information but I am not an iOS developer by practice.

the-great-emu-kerfuffle commented 3 years ago

App version is 2.11.1, the latest in the App Store. Not 2.11.3.

Edit: Issue is not replicated on the latest iPadOS Beta that released yesterday.

nicopasla commented 3 years ago

Same problem for me since today, restart help but temporarily

trparky commented 3 years ago

I have the same issue.

sunsetsonwheels commented 3 years ago

I can confirm the same issue on iOS 15 Beta 5, crashes when tapping icon on Home Screen/App Library as well as keyboard autofill.

ghost commented 3 years ago

Can confirm this is happening on iPad Pro iOS15 B5 as well but a simple shutdown from settings and turning back on will allow you to use bitwarden again until you close out from multitasking.

ax-meyer commented 3 years ago

Same behavior here. The first major bug I experience on the beta, and directly something with a big impact. Love my luck.

josephazrak commented 3 years ago

Can confirm I am facing the same issue on 15.0 (19A5318f) (beta 5). App crashes on open--rather high impact.

sleeping10 commented 3 years ago

Workaround for the moment if autofill stops working in safari use firefox works fine even when the app crash and if you need to access the app reinstall the app

trparky commented 3 years ago

I have submitted some feedback in the Apple Feedback app, apparently more than ten of you have submitted similar feedback to Apple. Keep it going guys, maybe it's something in the OS that's causing this issue.

Jeehut commented 3 years ago

Same problem here. As a workaround I'm now using vault.bitwarden.com in Safari which is not designed for Mobile, but does the job temporarily.

Just in case someone forgot. 😉

m4rkv5 commented 3 years ago

@Jeehut On my phone bitwarden runs for multiple hours after a reboot.

josephazrak commented 3 years ago

@Jeehut On my phone bitwarden runs for multiple hours after a reboot.

That makes sense--it's the time it takes for Jetsam to kill the app in the background naturally. The fact remains that once the app is closed, it will crash on reopen until the next reboot.

trparky commented 3 years ago

Any updates on this issue from the devs? Are we close to seeing a fix for this perhaps deployed via Test Flight? Or is this an iOS 15-related bug?

kkankala commented 3 years ago

Any update regarding the fix?

atridadl commented 3 years ago

Seems like an odd one to keep quiet on considering the impact it has.

TheJulianJES commented 3 years ago

It's possible that https://github.com/bitwarden/mobile/pull/1495 fixes this. (Or it's another "iPhone crash" bug)

takov751 commented 3 years ago

So far it's similar to the twitter app, however that app on the second time runs . I would be really interested what changed brought this behaviour

tdiehl commented 3 years ago

Seems to be affecting lots of Xamarin-based apps (including one I work on). See also xamarin/xamarin-macios#12427.

Wxfisch commented 3 years ago

I’ve seen the same behavior. Though I have not been able to use app fill at all until I reboot at which point as others have said it works for some time. I was directed to this one dude by support and find it odd that it’s not been assigned or even acknowledged by the devs really.

TheModdersDen commented 3 years ago

Same issue here. iOS build 15.0 beta 5 (19A5318f), iPhone 12 Pro.

I can temporarily resolve the issue by offloading the app and then re-downloading it, but can only keep it open for a short amount of time, as noted by others before it begins to crash again.

Uninstalling it and reinstalling it has the same effect, but again, not ideal.

Just thought I’d pitch my 2 cents here…

niclimcy commented 3 years ago

27885118-9DB2-4D5A-9465-5FA84AA8B443

iOS 15 Beta bug. It will be fixed in the next beta…

trparky commented 3 years ago

So, I guess that this may actually be a bug in iOS 15 Beta 5. Now let's hope that beta 6 is released this week and it contains the fix.

AlexHunterCodes commented 3 years ago

Polite reminder to everyone: stating you're also running the same version on the same beta and are also affected by this issue in the same way, or saying you're affected without posting any diagnostically useful or new information (like version numbers, and which beta branch and number you're running) doesn't help developers fix the issue any faster. It's just creating more noise they have to sift through. If your comment boils down to just saying "+1" use GitHub's emoji reactions to leave a 👍 on an existing comment, instead of cluttering the thread.

The issue already has a reliable repro on Beta 5, and appears to be an iOS issue that's affecting other Xamarin apps too, that Apple is already aware of and will likely be fixed in the next beta release, which developers will probably get early next week, and the public beta testers a couple of days later.

So this is probably a case of just being patient, and remembering that if you don't want to deal with bugs and crashes, don't run beta software on your primary devices.

TheJulianJES commented 3 years ago

Can reproduce on iOS 15 Developer Beta 6 (released today).

It's likely that if it's a fix on Apple's side, it didn't make it into today's beta. It should be in next week's beta. (They are now in the weekly release cycle.)

jerryc127 commented 3 years ago

Beta 6 still have this problem

ghost commented 3 years ago

BitwardeniOS-2021-08-18-105349.zip I have a stack trace if needed, Dev Beta 5, latest app store version. it stopped autofilling a while ago but still allowed app access... then it just stopped allowing app access. Device uptime is in the low double digits of days though. I'll update/reboot device and see if any more useful information can be gleaned from Dev Beta 6.

whatstevedid commented 3 years ago

Interesting post on the xamarin thread here: https://github.com/xamarin/xamarin-macios/issues/12427#issuecomment-900899606

Changing the minimum OS version to be 14.0 in the info.plist stopped the crash for this user.

Any way we could get a TestFlight version with this change to test?

trparky commented 3 years ago

Someone reported this...

Hi all. I was facing a similar issue, but got it working. I changed the minimum OS version to be 14.0 in the info.plist, and it doesn't crash on the 2nd load.

AlexHunterCodes commented 3 years ago

Changing the minimum OS version to be 14.0 in the info.plist stopped the crash for this user.

App currently has a minimum version of 10.0, so 14.0 is a big jump. I don't know what version spread Bitwarden's iOS users have, but it's probably not palatable for the team to drop so many older devices all at once. Especially not for the sake of something that might only be a temporary workaround for an issue that will likely be fixed in a later iOS beta or the final release.

The earlier comment about Apple changing their dynamic linker to improve app launch times suggests that too. My guess raising the minimum version eliminates some buggy or incomplete legacy compatibility codepath, resolving the crash.

Any way we could get a TestFlight version with this change to test?

We should figure out if this fix actually 100% works for the Bitwarden app first. I don't have a recent enough Mac to run the latest Xcode beta, so can't build it myself to find out. Any takers?

whatstevedid commented 3 years ago

We should figure out if this fix actually 100% works for the Bitwarden app first. I don't have a recent enough Mac to run the latest Xcode beta, so can't build it myself to find out. Any takers?

I have an M1 Macbook Air that I could use, though I don't have an Apple Developer account any more so not sure how much use I'd be?

niclimcy commented 3 years ago

I have an M1 Macbook Air that I could use, though I don't have an Apple Developer account any more so not sure how much use I'd be?

Not sure if I am just unfamiliar with visual studio / xcode but I can't seem to get bitwarden building with a free developer account. I am starting to think it's impossible since some of the app entitlements bitwarden uses requires a paid dev account.

whatstevedid commented 3 years ago

Just an update on this - looks like my feedback report that I submitted to Apple has now has the status changed to ‘potential fix identified’ - suggesting this should be sorted in an upcoming release. 30152E05-BE6C-43EF-B3DF-0D90E28E5EBF

eliykat commented 3 years ago

Hi everyone, I don't have much to add to this thread other than to say @AlexHunterCodes' comment here sums up my understanding of the issue. We've had some preliminary reports that iOS 15 Beta 6 solves the issue, but this does not seem to be the case for everyone. (Or that it solves the issue, but only if the app extension is not enabled.)

We expect that this crash will be resolved by continued beta releases and we'll continue to monitor this. I agree that we probably wouldn't want to bump the minimum version from 10 -> 14 solely to fix a bug in a beta iOS release.

Thanks everyone for your patience and for the helpful information in this thread.

AlexHunterCodes commented 3 years ago

Just upgraded to public beta 6 and confirm that I am still experiencing the same behaviour as beta 5. IPS crash files show the same Address size fault for the above repro steps. Also tried various combinations of disabling the app extension, killing both Bitwarden and Safari, rebooting the device and still crashes on the 2nd launch. Wasn't personally able to reproduce the preliminary reports of a fix.

Although, I think I do glimpse a single frame of the master password prompt screen now that I didn't see on beta 5. Might just be changes in the launch animation or me seeing what I want to see.

trparky commented 3 years ago

Apparently one developer managed to be able to fix it by setting the minimum iOS version to version 11 and it fixed the issue. Do you, @eliykat, would object to that? It's only one number increment from the current minimum of iOS v10.

hampton8 commented 3 years ago

If this is indeed the case but the BW team didn't want to change the minimum version at all (which is totally fair enough considering this is a bug with beta software), a Bitwarden Test Flight release with just this alteration made would be extremely helpful for those of us currently running the iOS 15 beta and who are unable to use the app (beta 6 didn't fix it for me either).

trparky commented 3 years ago

Yeah, but who really is still on anything older than iOS 12? There's got to be some kind of data out there to indicate how many people are on older iOS versions.

raifcoonjah commented 3 years ago

Yeah, but who really is still on anything older than iOS 12? There's got to be some kind of data out there to indicate how many people are on older iOS versions.

According to this report iOS: 12.x: 1.91%, anything below is 0%.

saoud commented 3 years ago

I agree a test flight release could solve the issue for us that are running the beta iOS and would be greatly appreciated.

dfuentes03 commented 3 years ago

I agree a test flight release could solve the issue for us that are running the beta iOS and would be greatly appreciated.

Agreed... this has so far been the most intrusive bug since I've been on iOS 15 Dev Beta since day 1. I do pay for BitWarden to support the continued development of this application, however, this bug has me contemplating migrating all my stored items to another password manager for the time being... which ultimately can result in me switching over permanently.

saoud commented 3 years ago

I agree a test flight release could solve the issue for us that are running the beta iOS and would be greatly appreciated.

Agreed... this has so far been the most intrusive bug since I've been on iOS 15 Dev Beta since day 1. I do pay for BitWarden to support the continued development of this application, however, this bug has me contemplating migrating all my stored items to another password manager for the time being... which ultimately can result in me switching over permanently.

I was thinking about doing the same thing but it seems like a huge hassle when a TestFlight version with an updated min iOS version would be a very easy fix for the devs. I do also pay for the application and have been loving it so far.

LastPass was awful, I am not going to switch to dashlane so the thing I would be thinking about doing is using the iCloud password manager I just don't really want to migrate all my data over to that nor am I sure if there is an easy way to do so.

karassm commented 3 years ago

I confirm the bug is still present in Beta 6 (public beta, on iPhone 12). A TestFlight version is a very good idea.

Edit : the app seems to work but not the extension (tested on safari, chrome, etc)

hampton8 commented 3 years ago

The app isn't working for me on beta 6. Crashes after a relaunch just as before.

dfuentes03 commented 3 years ago

I agree a test flight release could solve the issue for us that are running the beta iOS and would be greatly appreciated.

Agreed... this has so far been the most intrusive bug since I've been on iOS 15 Dev Beta since day 1. I do pay for BitWarden to support the continued development of this application, however, this bug has me contemplating migrating all my stored items to another password manager for the time being... which ultimately can result in me switching over permanently.

I was thinking about doing the same thing but it seems like a huge hassle when a TestFlight version with an updated min iOS version would be a very easy fix for the devs. I do also pay for the application and have been loving it so far.

LastPass was awful, I am not going to switch to dashlane so the thing I would be thinking about doing is using the iCloud password manager I just don't really want to migrate all my data over to that nor am I sure if there is an easy way to do so.

I'm right there with you on LastPass and Dashlane... 1Password was what I had in mind, especially since I get access to a free family account via my organization's business account.

@eliykat What's blocking updating the minimum iOS version? I'm sure you guys have access to analytics and can easily pull up what iOS versions your users are on... Just to give you an example, even the iPhone 5S and iPad mini 2 support iOS 11 - both devices were released way back in 2013! I'm positive that you have very little, if any, users on iOS 10..

dfuentes03 commented 3 years ago

I confirm the bug is still present in Beta 6 (public beta, on iPhone 12). A TestFlight version is a very good idea.

Edit : the app seems to work but not the extension (tested on safari, chrome, etc)

Give it some time - it'll stop working as well 😭

hampton8 commented 3 years ago

Apparently one developer managed to be able to fix it by setting the minimum iOS version to version 11 and it fixed the issue.

Has anyone here actually been able to confirm this first hand, out of interest?

pyrox82 commented 3 years ago

Hi,

for me, the app is working in iOS 15 Beta 6 if you disable the automatic fill (Settings -> Passwords). Then I can at least use the app and copy the credentials and past them manually. Hope to get it fixed soon.

josephazrak commented 3 years ago

Hi,

for me, the app is working in iOS 15 Beta 6 if you disable the automatic fill (Settings -> Passwords). Then I can at least use the app and copy the credentials and past them manually. Hope to get it fixed soon.

This does not work for me. Disabling Autofill as you suggest still causes app to crash.