bitwarden / android

Bitwarden mobile app for Android.
https://bitwarden.com
GNU General Public License v3.0
6.29k stars 794 forks source link

App Crash on iOS 15 Beta 5 #1493

Closed sso-bitwarden closed 2 years ago

sso-bitwarden commented 3 years ago

I am able to log in. Regardless of whether or not I make any changes to the settings (enable FaceID or not, change timeouts, etc.) the app will immediately close out as soon as I reopen the app. An ips is generated and the stack racestarts with (if it helps):

"exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"}, "asi" : {"libsystem_c.dylib":["abort() called"]}, "lastExceptionBacktrace" : [{"imageOffset":628456,"imageIndex":5},{"imageOffset":89956,"imageIndex":6},{"imageOffset":1532244,"imageIndex":5},{"imageOffset":188548,"imageIndex":5},{"imageOffset":184768,"imageIndex":5},{"imageOffset":1792184,"imageIndex":11},{"imageOffset":767644,"imageIndex":5},{"imageOffset":836336,"imageIndex":5},{"imageOffset":23652,"imageIndex":5},{"imageOffset":46084,"imageIndex":5},{"imageOffset":126920,"imageIndex":5},{"imageOffset":5004,"imageIndex":8},{"imageOffset":5340688,"imageIndex":9},{"imageOffset":2713072,"imageIndex":9},{"imageOffset":5973944,"imageIndex":3},{"imageOffset":5262784,"imageIndex":3},{"imageOffset":5262660,"imageIndex":3},{"imageOffset":595272,"imageIndex":3},{"imageOffset":4415840,"imageIndex":3},{"imageOffset":284552,"imageIndex":4},{"imageOffset":1055304,"imageIndex":4},{"imageOffset":1080480,"imageIndex":4},{"imageOffset":143556,"imageIndex":4},{"imageOffset":34310384,"imageIndex":3},{"imageOffset":595088,"imageIndex":3},{"imageOffset":105252,"imageIndex":10}], "faultingThread" : 0, "threads" : [{"triggered":true,"id":371738,"threadState":{"x":[{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":10000000},{"value":5120},{"value":18446744069414586880},{"value":9007292605623196026},{"value":9007292609895505146},{"value":1000},{"value":12532993},{"value":16393},{"value":4763844608},{"value":16383},{"value":33922},{"value":328},{"value":4345218432},{"value":0},{"value":6},{"value":259},{"value":4345218656},{"value":4749022304},{"value":4764860752},{"value":4763726336},{"value":4379446488},{"value":4764860928},{"value":5},{"value":4309885279}],"flavor":"ARM_THREAD_STATE64","lr":{"value":8390571060},"cpsr":{"value":1073741824},"fp":{"value":6161400176},"sp":{"value":6161400144},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":7425071544,"matchesCrashFrame":1},"far":{"value":6165807040}},"name":"tid_103","queue":"com.apple.main-thread","frames":[{"imageOffset":31160,"imageIndex":0},{"imageOffset":29748,"imageIndex":1},

Environment

pyrox82 commented 3 years ago

Hi, for me, the app is working in iOS 15 Beta 6 if you disable the automatic fill (Settings -> Passwords). Then I can at least use the app and copy the credentials and past them manually. Hope to get it fixed soon.

This does not work for me. Disabling Autofill as you suggest still causes app to crash.

You are right. Sorry. As soon as I close the app it will not start again. :(

kspearrin commented 3 years ago

As suggested by some as a workaround, we've submitted an update to Apple on the TestFlight public track that bumps the minimum iOS version to v12. Once it is approved by Apple, we will post a link to access it from the TestFlight app.

hampton8 commented 3 years ago

That's awesome Kyle, thank you so much! Not having easy access to Bitwarden for a while makes you realise just how crucial this software is to your everyday life!

AlexHunterCodes commented 3 years ago

As suggested by some as a workaround, we've submitted an update to Apple on the TestFlight public track that bumps the minimum iOS version to v12. Once it is approved by Apple, we will post a link to access it from the TestFlight app.

Thanks, that's really appreciated. Will the TestFlight link just be for existing members to download the new release, or will the program open to new applicants too (can't find a public link)? Here's hoping Apple approve it before they release beta 7 with a fix on Monday or Tuesday morning. 😆

I do pay for BitWarden to support the continued development of this application, however, this bug has me contemplating migrating all my stored items to another password manager for the time being... which ultimately can result in me switching over permanently.

I'm a paying customer too, but I think it's extremely sad that some users felt the need to strong-arm Bitwarden with "an offer they couldn't refuse". It's unfair and unconstructive, and just not how we do things in open source. The iOS 15 beta is opt-in and you should expect bugs that disrupt your workflow, which is why nobody recommends running betas on critical devices. You knew what you were signing up for, no one forced you to upgrade, and its unfair to demand developers support their app on a constantly shifting unsupported OS version when they don't have to. In this case it's nice that they did, but only after you threatened them, which is just kinda yucky.

Migrating to another password manager and cutting your nose off to spite your face both take a huge investment of time and effort. Do you know what would be easier? Recognising that the current state of the iOS beta isn't suitable for your needs or workflow, and downgrading to iOS 14 stable (or even just to 15.0 beta 4) and restoring a backup. Apple's made downgrades and backup restores pretty painless nowadays.

trparky commented 3 years ago

As suggested by some as a workaround, we've submitted an update to Apple on the TestFlight public track that bumps the minimum iOS version to v12. Once it is approved by Apple, we will post a link to access it from the TestFlight app.

Like @AlexHunterCodes said, I appreciate it. Getting a link posted to the Test Flight version of the app will be greatly appreciated.

spencer-gre commented 3 years ago

Hi!

Initially I was just unable to auto fill on the latest IOS Beta so I would resort to copying from the app. Now, the app crashes on launch. Glad to see that others are encountering same bug.

trparky commented 3 years ago

Someone mentioned this...

"release builds with LLVM work without having to modify the deployment target."

hlafaille commented 3 years ago

Same issue here, hopefully TestFlight gets approved soon. Just switched to BitWarden and I really like it, but would like to try out the new iOS and it crashes unless I uninstall the app.

Roundlay commented 3 years ago

+1… Awaiting TestFlight link. (:

kspearrin commented 3 years ago

Here is a public link to testflight with a build targeting iOS 12 minimum. Please report back if this resolves the problem.

https://testflight.apple.com/join/595lFH7U

Nexus237 commented 3 years ago

Here is a public link to testflight with a build targeting iOS 12 minimum. Please report back if this resolves the problem.

https://testflight.apple.com/join/595lFH7U

Thanks @kspearrin

trparky commented 3 years ago

Nope, still crashes on my iPhone 11 Pro.

tomsinclair94 commented 3 years ago

Can confirm also still crashing on iPhone 12 Pro - TestFlight had 3 crash “popups” as if it tried to open multiple times

takov751 commented 3 years ago

Same on iPhone 11 crash popup 3x. Plot thickens it seems

dfuentes03 commented 3 years ago

iPhone 12 Pro Max on iOS 15 B6

The first launch of the application was successful. I then quit the application by swiping up on it in the app switcher and instantly got a "Bitwarden Crashed" popup. Any subsequent attempt to launch Bitwarden just results in the app crash popup being displayed.

kspearrin commented 3 years ago

Thanks all. We'll see if there is something else we can try.

dfuentes03 commented 3 years ago

Thanks all. We'll see if there is something else we can try.

Anything we can collect and get to you to facilitate determining root cause? Or is sending the TestFlight Application Crash report when we get the popup sufficient?

Vladx71 commented 3 years ago

Still crashing with the latest public beta after the first successful start

L:

On Mon, Aug 23, 2021 at 3:38 PM Nexus @.***> wrote:

Here is a public link to testflight with a build targeting iOS 12 minimum. Please report back if this resolves the problem.

https://testflight.apple.com/join/595lFH7U

Thanks @kspearrin https://github.com/kspearrin

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitwarden/mobile/issues/1493#issuecomment-903777691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3RO2TDK3UPGW4RME5S7WTT6JFN3ANCNFSM5B5W6IXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

karassm commented 3 years ago

Same crash on iphone 12 ios 15b6

Sent from ProtonMail for iOS

Le lun., août 23, 2021 à 15:35, Kyle Spearrin @.***> a écrit :

Here is a public link to testflight with a build targeting iOS 12 minimum. Please report back if this resolves the problem.

https://testflight.apple.com/join/595lFH7U

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

trparky commented 3 years ago

@kspearrin Someone mentioned something about LLVM over at the Xamarin project. Does that make any sense?

trparky commented 3 years ago

@kspearrin https://mallibone.com/post/custom-targets-llvm Something about how to enable LLVM during compilation.

spencer-gre commented 3 years ago

Thought I'd share that I no longer crash on B6 (meaning I can open the app) but the auto fill/keyboard extension is unusable.

craigmpeters commented 3 years ago

iPhone 10S Max 15.0 (19A5325f) initially worked including safari but first launch after using safari it now crashes each attempt to launch.

kspearrin commented 3 years ago

I just added build 2.12.0 (846) to the public testflight track. Please try this and report back. It has LLVM enabled as a suggested workaround.

trparky commented 3 years ago

Well, we have a new issue. Great. It crashes on exit, however... it launches after the app crashes whereas before, it didn't. One step forward, I guess.

rbrussell82 commented 3 years ago

I just added build 2.12.0 (846) to the public testflight track. Please try this and report back. It has LLVM enabled as a suggested workaround.

This seems to fix the app crashes for me on an iPhone 11 Pro Max, BUT AutoFill doesn't seem to be working. It never opens the passwords for me or if it detects a saved login and I click on it, it doesn't do anything.

nicopasla commented 3 years ago

Build 846 work perfectly fine for me except auto fill Edit: I talked too fast, auto fill is not working correctly Auto fill was working at start even with the app restarting but after 2-3 tries it crash

rbrussell82 commented 3 years ago

I just added build 2.12.0 (846) to the public testflight track. Please try this and report back. It has LLVM enabled as a suggested workaround.

This seems to fix the app crashes for me on an iPhone 11 Pro Max, BUT AutoFill doesn't seem to be working. It never opens the passwords for me or if it detects a saved login and I click on it, it doesn't do anything.

AutoFill does seem to be working for me after restarting the phone. No crashes here after a phone reboot.

trparky commented 3 years ago

I rebooted my phone; the app still crashes on exit however the app works. Something about small victories.

craigmpeters commented 3 years ago

Updated build: auto fill worked once but then didn't, it currently does not crash when using the app after this which is different from my test done previously.

MrAshieB commented 3 years ago

Build 2.12.0 (846) no longer crashing on launch, but does crash on closing, prompting a pop-up to report to devs.

takov751 commented 3 years ago

Build 2.12.0 (846) no longer crashing on launch, but does crash on closing, prompting a pop-up to report to devs.

Exactly the same 👌 so it seems the solution is in reach

oaklandm commented 3 years ago

Yep seems to have fixed the crash on launch, thanks for finding the fix. I haven't experienced a crash on exit, or any crashes at all

manikanta-dornala commented 3 years ago

Is there scope for some conspiracy theory here?

kspearrin commented 3 years ago

We just uploaded build 2.12.0 (848) that might fix also the autofill extensions. Please let us know.

manikanta-dornala commented 3 years ago

Can confirm that with build 2.12.0 (848) both Autofill and App work without crashing on iPhone 12 pro max with 15.0 Beta 5 (19A5325f).

josephazrak commented 3 years ago

Can confirm that the application now functions without crashing as of TF build 848. Auto fill works too.

App crashes on task switcher exit, though.

karassm commented 3 years ago

With build 848 on iphone 12 ios15b6 : tested ok (app + autofill) on safari, chrome and firefox focus... no crash yet. Thanks a lot for the availability on TestFlight !

niclimcy commented 3 years ago

Steps to reproduce crash on exit:

1) Open bitwarden 2) Open recents 3) Close bitwarden from recents 4) Bitwarden crashes

It is crucial to not go back to the homescreen before closing Bitwarden as that scenario is working fine

dfuentes03 commented 3 years ago

Thanks to the Bitwarden team for hearing their users and getting this fixed even if on iOS Beta software! Another reason to continue using and paying for your product.

hv0905 commented 3 years ago

Build 848 works well on ios15 beta6(iphone8plus) Thanks a lot for the fix!

egadsthefuzz commented 3 years ago

Steps to reproduce crash on exit:

1) Open bitwarden

2) Open recents

3) Close bitwarden from recents

4) Bitwarden crashes

It is crucial to not go back to the homescreen before closing Bitwarden as that scenario is working fine

I can reproduce on 848 using this, autofill now works though

niclimcy commented 3 years ago

For people still looking for the testflight link:

https://testflight.apple.com/join/595lFH7U

xiangsanliu commented 3 years ago

Steps to reproduce crash on exit:

  1. Open bitwarden
  2. Open recents
  3. Close bitwarden from recents
  4. Bitwarden crashes

It is crucial to not go back to the homescreen before closing Bitwarden as that scenario is working fine

I can reproduce on 848 using this, autofill now works though

Same problem on 848 and iOS15 beta.

rbrussell82 commented 3 years ago

iOS Beta 7 just dropped.

From initial reports on Reddit in /r/iOSBeta it appears that the App Store version of Bitwarden works again without crashes. I haven't tested yet as Beta 7 is still downloading for me.

the-great-emu-kerfuffle commented 3 years ago

I can confirm that Bitwarden 2.11.1 works as expected on both iOS and iPadOS Beta 7. The app does not crash when closed from task manager (without going to the Home Screen first). It also reopens after closure.

I have not tested the keyboard extension/autofill, however, because I don’t use it. Just the app itself.

SwiftCoderJoe commented 3 years ago

I can confirm the autofill extension also works on Beta 7.

trparky commented 3 years ago

Alright guys, I did a test. I downloaded and installed iOS 15 Public Beta 7 and the test flight version of BitWarden, while it works, continues to crash when you swipe it off the multitasking screen. So, I decided to throw caution to the wind and had the AppStore re-download BitWarden app version 2.11.1 (704). I then did a full reboot of the phone and launched the app (v2.11.1) and then swiped it off the multitasking screen. No crash. Yay. I then did a re-launch of the app and guess what... no crash. Double yay!

So, what does this mean? It basically means that @kspearrin can disable LLVM in the compilation of the iOS app and go back to the normal way of compiling an iOS app and we should be good to go.

trparky commented 3 years ago

In other words, Apple fixed the true underlining issue that was causing all of our issues in iOS Public Beta 7.

TheJulianJES commented 3 years ago

When downloading from the iOS App Store and then swiping up the app in the multitask switcher (to close it), it might still crash (very likely). You just don't get the popup because it's not a TestFlight build. So there is still an issue with the iOS beta.